1023824 - [Homescreen] Label size should remain the same from 3 to 4 grid

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Eric Pang [:epang] UX]

Currently the labels on homescreen shrink in size when switching from the 3 to 4 icon grid.  The label size should remain the same in both.  

This also effects the search app since it follows the same label size as the homescreen.

Comment 1

[Cristian Rodriguez (:crdlc)]

This is done in CSS [1] but there was a problem with web components. I've installed the latest build and font sizes for apps seem the same thought. Could you double check it?

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_grid/style.css#L59

Comment 2

[Eric Pang [:epang] UX]

Attachment: homescreen grid.jpg

Hi Cristian, I've installed today's build and I'm still seeing it.  See the attach screen.  This is the build i flashed: https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-flame/latest/

Is it the wrong one?  

Let me know, thanks!

Comment 3

[Jason Smith [:jsmith]]

I don't think I'd block the release on this. It's nice cleanup work, but not a critical blocker.

Comment 4

[Cristian Rodriguez (:crdlc)]

Sorry no idea, I cannot open that URL because I am from Telefonica :) 
My build is gaia: master Gecko: 5cc2c0b.Gaia-981168c
A bug was filed regarding to font size and if you see the attachment in bug 1023817 you can see that the font size is the same now. Maybe Franceso can help you 

(In reply to Eric Pang [:epang] from comment #2)
> Created attachment 8438405 [details]
> homescreen grid.jpg
> 
> Hi Cristian, I've installed today's build and I'm still seeing it.  See the
> attach screen.  This is the build i flashed:
> https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-
> central-flame/latest/
> 
> Is it the wrong one?  
> 
> Let me know, thanks!

Comment 5

[Cristian Rodriguez (:crdlc)]

upps I didn't add the ni?

Comment 6

[Francesco Lodolo [:flod]]

I flashed that build, but it doesn't seem very updated.

Build ID: 20140610040208
Git commit: f42ebc93

On 4 columns I get the small font, on 3 columns the bigger font. Current builds get the same font, which causes bug 1023817.

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Flame 4 columns

This is how the Flame with 4 columns currently looks if I flash the current Gaia on top of that image. 

Git version: 6b5be16c from 2014-06-11

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: 320x480 both grids

Maybe we have a problem with resolutions because in 320x480 works fine, Kevin, do you have a Flame to test it? Thanks

Comment 9

[Kevin Grandon :kgrandon]

ni? myself to take a look.

Comment 10

[Francesco Lodolo [:flod]]

Sorry, not sure if my comment was clear: the build currently available for Flame (link to pvt) has that issue, but a current build of Gaia works as expected (font doesn't change).

Compare this (recent build)
https://bugzilla.mozilla.org/attachment.cgi?id=8438459

With the right one here
https://bug1023824.bugzilla.mozilla.org/attachment.cgi?id=8438405

I see the bigger font on both Keon and Flame, that's why I filed the other bug. For me this bugs is a WORKSFORME.

Comment 11

[Kevin Grandon :kgrandon]

There was a bug before, but I just landed something yesterday to address this: https://github.com/mozilla-b2g/gaia/commit/4d2841771e6e2d62a4bdba93116ed7b27239a0b0

This should be resolved either with the latest master or the nightly build from today/tomorrow.

Comment 12

[Eric Pang [:epang] UX]

(In reply to Kevin Grandon :kgrandon from comment #11)
> There was a bug before, but I just landed something yesterday to address
> this:
> https://github.com/mozilla-b2g/gaia/commit/
> 4d2841771e6e2d62a4bdba93116ed7b27239a0b0
> 
> This should be resolved either with the latest master or the nightly build
> from today/tomorrow.

Great, thanks guys!